[webkit-dev] Extra review requirement for web-facing API? (Was: Re: Spellcheck API for WebKit)

Ryosuke Niwa rniwa at webkit.org
Wed Jun 22 11:49:55 PDT 2011

Per IRC discussion, I propose to add a Wiki page that states what needs to
be checked/reviewed for new Web-facing API to avoid adding new
policy/process to the review process.  This page is not meant as a mandatory
checklist but rather a guide that reviewers can use to ensure he/she is
reviewing that needs to be reviewed.  It should help new reviewers learn how
to review new Web-facing APIs.

- Ryosuke

On Wed, Jun 22, 2011 at 11:43 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> On Wed, Jun 22, 2011 at 11:38 AM, Eric Seidel <eric at webkit.org> wrote:
>> I think it's better for our reviewers to review only things they're
>> comfortable with.
> But I don't think being comfortable may not necessarily mean that the
> reviewer knows all implications of the change.
> On Wed, Jun 22, 2011 at 11:41 AM, Dimitri Glazkov <dglazkov at chromium.org>
>  wrote:
>> To prevent this from happening again, we should remind everyone to:
>> 1) Only review things they are comfortable with;
>> 2) Seek WebKit elder's review for public-facing APIs
>> I don't think we need an explicit two-level review policy. If
>> anything, we need super-reviewers instead.
> I'm supportive of super-reviewers idea.
> - Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110622/8ea7627c/attachment.html>

More information about the webkit-dev mailing list