[webkit-dev] 194 bugs in pending-commit
dpranke at chromium.org
Mon Jun 20 11:35:12 PDT 2011
I had one of the bugs in this state, and I had not landed it because I
had been meaning to do some more testing to see if it caused
regressions. However, someone CQ+'ed it over the weekend, and it was
committed w/o my involvement. Fortunately, it did not appear to cause
massive regressions (thankfully, since I wasn't around and wouldn't
have been able to triage/diagnose any issues), but, for at least some
patches, I would like to prevent this from occurring in the future.
Would it have been better to mark the patch as CQ- just to be safer
(and clearer), or is there some other recommended way to indicate that
I want a patch to be reviewed but it may not be ready to be landed?
On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth <abarth at webkit.org> wrote:
> There are a 194 open bugs with an R+ patches attached to them:
> Please take a minute to look through this list and clean out any bugs
> you know about. (Looks like 5 of them are assigned to me, so I'll be
> following my own advice shortly.) Some recommended actions:
> 1) Close the bug if the patch has already been landed.
> 2) Mark the patch as obsolete / clear the review flag if we're not
> going to land the patch.
> 3) Mark the patch commit-queue+ if you'd like the commit queue to land
> the patch.
> 4) Land the patch manually if the patch needs some tweaking before landing.
> Thanks, and happy bug scrubbing!
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
More information about the webkit-dev