[webkit-dev] review flags (was bugs in pending-commit)
eric at webkit.org
Sun Jun 19 18:36:21 PDT 2011
It might get a little squirrelly to have things like:
LANDED(12345): REVERTED(12344): LANDED(12343): Patch
But I'm happy to write up the patches to make it so.
On Sun, Jun 19, 2011 at 6:32 PM, Antonio Gomes <tonikitoo at gmail.com> wrote:
> Personally, I like this pattern a lot.
> Would it also be helpful when sheriff bot rolls out a patch to attach the
> rolled out patch with a nice description like ROLLOUT(rXXXXX) to the bug?
> On Sun, Jun 19, 2011 at 8:36 PM, Eric Seidel <eric at webkit.org> wrote:
>> On Sun, Jun 19, 2011 at 11:31 AM, Darin Adler <darin at apple.com> wrote:
>> > On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote:
>> >> I actually do not like the way the review flags are cleared today only
>> >> in order to make the tools and pending-xxx pages happier. IMO the review
>> >> flags give much about the history of the bug. In that matter, I dislike
>> >> webkit-patch's ways of clearing "r-" flags of patches while it marks it as
>> >> obsolete and uploads a new one. Reason: an easy-to-see r-'ed patch is very
>> >> helpful to me to understand the chronological progresses in the bug.
>> > I agree that it would be clearer to leave review flags for clarity about
>> > the history of a patch. I also have been irritated by our work flow that
>> > involves clearing review flags to appease the tools.
>> > However, even if we fixed everything so that was no longer necessary, I
>> > would still want a way to clearly communicate “this patch is known to be bad
>> > and not suitable for landing, despite the fact that a reviewer approved it
>> > at one point”.
>> > And I also think that if we were redesigning the bug system it would be
>> > good if there was a way to communicate that a patch was landed other than
>> > having a bug marked RESOLVED, because people continue to put multiple
>> > patches in a single bug, and so the bugs state can’t really tell us the
>> > status of a patch.
>> I'm happy to change webkit-patch to change the descriptions on patches
>> to prefix "LANDED(r12354):" when landing/obsoleting, etc. if you think
>> that would help.
>> > -- Darin
>> > _______________________________________________
>> > webkit-dev mailing list
>> > webkit-dev at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
> --Antonio Gomes
More information about the webkit-dev