[webkit-dev] Adding ENABLE_FLEXBOX to WebCore

[Tony Chang]

Sure, no problem.  I'll rename it to ENALBE_NEW_FLEXBOX.

On Fri, Jun 10, 2011 at 6:12 PM, Sam Weinig <weinig at apple.com> wrote:

> Since it is confusing to me (and may be to others), perhaps a different
> name than ENABLE_FLEXBOX should be used, given that we already have flexbox.
> Maybe, ENABLE_NEW_FLEXBOX?
>
> -Sam
>
> On Jun 10, 2011, at 2:42 PM, David Hyatt wrote:
>
> Just so people know, it was my recommendation that they just start with a
> new renderer and implementation.
>
> Some other recommendations I would make here (apologies if they have been
> implemented already):
>
> (1) Rename the current RenderFlexibleBox to put "deprecated" into the name,
> e.g., RenderDeprecatedFlexibleBox.
>
> (2) The old flexbox was never patched for vertical writing modes. Please
> make sure when you build the new renderer from the ground up that you take
> this into account.
>
> (3) Please consult with rendering experts for any changes you have to make
> to base classes, especially RenderBlock and RenderBox. We may be able to
> help simplify some of that code, especially compared to the old flexbox.
>
> (4) Use the old flexbox code as a rough guide, but be aware of its issues,
> e.g., too much layout when flexing, box-ordinal stuff is very slow, etc. I
> think some of the bugs you tried to fix already should inform this somewhat.
>
> Definitely keep rendering experts in the loop on this and have fun
> implementing!
>
> Dave
>
>
> On Jun 8, 2011, at 10:57 AM, Tony Chang wrote:
>
> Hi webkit-dev,
>
> I wanted to let you know that Ojan and I plan to add flexbox layout support
> to WebCore.  WebCore already supports an older flexbox implementation
> (display: box), but the new spec is designed to be easier for developers to
> understand and more powerful.  The old flexbox will still remain in WebCore
> since none of the CSS properties overlap with the new flexbox spec.  The
> spec can be found at: http://www.w3.org/TR/css3-flexbox/ (
> http://dev.w3.org/csswg/css3-flexbox/<http://dev.w3.org/csswg/css3-flexbox/#negative-flexibility>
> )
>
> This support will be behind the ENABLE_FLEXBOX feature define (
> https://bugs.webkit.org/show_bug.cgi?id=62049) and there is a meta bug
> tracking the feature's development (
> https://bugs.webkit.org/show_bug.cgi?id=62048).  I expect this feature to
> eventually be enabled by all ports.
>
> I am ready to setup a buildbot for tracking the compile and flexbox related
> layout tests.  Should I go ahead and get this added to build.webkit.org's
> waterfall?
>
> Thanks,
> Tony
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110613/194cc936/attachment.html>