[webkit-dev] style checking and build failed without any useful info.

Adam Barth abarth at webkit.org
Thu Jan 27 21:50:11 PST 2011


On Thu, Jan 27, 2011 at 9:48 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> I'm surprised that you don't use "Tools/Scripts/webkit-patch upload <bug
> number>".

That uses git diff under the covers.  I'm pretty sure it uses
--binary.  In any case, the system is optimized for patches produced
with webkit-patch.

Adam


> On Thu, Jan 27, 2011 at 9:43 PM, Jia Pu <jpu at apple.com> wrote:
>>
>> On Jan 27, 2011, at 9:07 PM, Jia Pu wrote:
>>
>> I just tried again, and got the same failure.
>> There two things I can think of that are different from the patches I have
>> submitted before:
>> 1. This is the first time I use git-diff instead of svn-create-patch to
>> generate the patch.
>>
>> Now think about, it may has something to do with diff on binary files.
>> Shall I use --binary with git-diff, or some other script I don't know of?
>>
>> 2. This patch is significantly larger, $190KB.
>> Adam, please take a look at the log when you get a chance.
>> Thanks.
>>
>> On Jan 27, 2011, at 6:32 PM, Adam Barth wrote:
>>
>> Strange.  We've had problems before where the writes don't quite make
>> it all the way to AppEngine (which hosts queues.webkit.org), but it's
>> strange that all the bots would run into the same problem.  It might
>> be worth uploading the patch again to see if the problem recurs.  Eric
>> or I can also dig into the logs to get more details about what
>> happened.
>>
>> Adam
>>
>>
>> On Thu, Jan 27, 2011 at 6:27 PM, Jia Pu <jpu at apple.com> wrote:
>>
>> What can I do when style checking and build bot all failed without any
>>
>> useful info?
>>
>> https://webkit-commit-queue.appspot.com/patch/80372
>>
>> The patch did build and pass style checking locally.
>>
>> Thanks.
>>
>> Jia
>>
>> _______________________________________________
>>
>> webkit-dev mailing list
>>
>> webkit-dev at lists.webkit.org
>>
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>>
>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>


More information about the webkit-dev mailing list