[webkit-dev] make-script-test-wrappers not being maintained

Darin Adler darin at apple.com
Tue Jan 18 16:55:20 PST 2011

On Jan 18, 2011, at 4:49 PM, Ojan Vafai wrote:

> On Tue, Jan 18, 2011 at 4:46 PM, Simon Fraser <simon.fraser at apple.com> wrote:
> It would be good if the generated HTML had a big <!-- THIS IS AUTOGENERATED, DO NOT COPY OR EDIT --> in it.
> I agree this would be valuable.

We should do it.

> If you need a non-standard wrapper, don't put the JS file in the script-tests directory.

That’s a good idea. We should have done that when we created the script-tests directory. The exclusions list predates that directory.

> If you need shared JS resources, they should go in the resources directory, not in the script-tests directory.

That’s already done, I think.

> We should not need any exclusions AFAIK and should remove the concept of exclusions from the generator script entirely.


> Also, there's been a number of discussions about this on webkit-dev.

I didn’t remember that.

> There seemed to be general consensus then that we should eliminate or simplify this generator script.


> All we need to do is fix js-test-pre.js to use onload events to eliminate the need for js-test-post.js.

Maybe that will work for almost all the tests.

    -- Darin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110118/46762f0d/attachment.html>

More information about the webkit-dev mailing list