[webkit-dev] make-script-test-wrappers not being maintained

Tue Jan 18 16:49:44 PST 2011

On Tue, Jan 18, 2011 at 4:46 PM, Simon Fraser <simon.fraser at apple.com>wrote:

> On Jan 18, 2011, at 4:30 PM, Darin Adler wrote:
> > Any ideas on how to improve the situation?
>
> I usually take an existing .html file for a script test and modify it. It
> would be good if the generated HTML had a big <!-- THIS IS AUTOGENERATED, DO
> NOT COPY OR EDIT --> in it.

I agree this would be valuable.

If you need a non-standard wrapper, don't put the JS file in the
script-tests directory. If you need shared JS resources, they should go in
the resources directory, not in the script-tests directory. We should not
need any exclusions AFAIK and should remove the concept of exclusions from
the generator script entirely.

Also, there's been a number of discussions about this on webkit-dev. There
seemed to be general consensus then that we should eliminate or simplify
this generator script. All we need to do is fix js-test-pre.js to use onload
events to eliminate the need for js-test-post.js. Then we don't need the
generator script and can just write these tests by hand.

Pure script test (possibly generated by a script):

<!DocType html>

<script src="path/to/js-test-pre.js"></script>

<script src="path/to/test.js"></script>

Regular test (hand rolled):

<!DocType html>

Ojan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110118/4b62a31a/attachment.html>