[webkit-dev] Trouble with updating Chromium' slayout test expectations

Mikhail Naganov mnaganov at chromium.org
Tue Feb 22 10:43:42 PST 2011


Ah, true. The code changes were long ago.

On Tue, Feb 22, 2011 at 21:40, Mihai Parparita <mihaip at chromium.org> wrote:
> But these were rebaselines, which don't depend on any code changes.
>
> Mihai
>
> On Tue, Feb 22, 2011 at 10:35 AM, Mikhail Naganov <mnaganov at chromium.org> wrote:
>> I have a suspicion that the cause of canaries failures is described
>> here: https://groups.google.com/a/google.com/group/chrome-webkit-gardening/browse_thread/thread/d3b3a4fc647e804d
>> In short, bots can run tests prematurely, emitting false failures. I
>> observed this during my gardening, and I think you should check which
>> revisions of WebKit and Chromium bots used while running tests.
>>
>> On Tue, Feb 22, 2011 at 20:16, Drew Wilson <atwilson at google.com> wrote:
>>> Yeah, it's weird. I rebaselined those tests, but the chromium canaries still
>>> showed them as red. Now, however, the canaries are showing many of them
>>> passing. I was planning to remove the lines from test_expectations today to
>>> see if they stay green.
>>> -atw
>>>
>>> On Tue, Feb 22, 2011 at 6:46 AM, Mihai Parparita <mihaip at chromium.org>
>>> wrote:
>>>>
>>>> It looks like Drew checked in baselines with
>>>> http://trac.webkit.org/changeset/79034 (which may be why
>>>> rebaseline-chromium-webkit-tests isn't doing anything, since it
>>>> already has "correct" pixel baselines), but given
>>>> http://trac.webkit.org/changeset/79088 it didn't seem to work. Drew,
>>>> any ideas why?
>>>>
>>>> Mihai
>>>>
>>>> On Tue, Feb 22, 2011 at 2:07 AM, Hajime Morita <morrita at google.com> wrote:
>>>> > Hi Chromium WebKit folks,
>>>> >
>>>> > I'm looking for a help to retrieve the latest expectation files for
>>>> > Chromium Mac LayoutTest.
>>>> > At the weekend there was a change that triggers massive amount of
>>>> > pixel test failures that requires rebaselining.
>>>> > (https://bugs.webkit.org/b/54736)
>>>> > But the buildbot doesn't have the latest result for part of them, that
>>>> > means
>>>> >
>>>> >  * rebaseline-chromium-webkit-tests doesn't update pixel results
>>>> >  * [layout test results] links on buildbot dashboard are broken.
>>>> >
>>>> > Then now around 100 tests for Mac Chromium are
>>>> > left marked as failed (BUGWK54736 lines), waiting for their fresh
>>>> > expectations.
>>>> >
>>>> > Unfortunately I have no idea what's happening
>>>> > but missing 100 tests will possibly hurt us.
>>>> > How could I update these expectations?
>>>> > Any suggestions and/or helps are appreciated.
>>>> >
>>>> > Regards.
>>>> > --
>>>> > morrita
>>>> > _______________________________________________
>>>> > webkit-dev mailing list
>>>> > webkit-dev at lists.webkit.org
>>>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>> >
>>>
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>
>


More information about the webkit-dev mailing list