[webkit-dev] code review tool changes

Ojan Vafai ojan at chromium.org
Mon Feb 14 21:47:37 PST 2011


shift+click can now be used to extend the context for a comment.
http://trac.webkit.org/changeset/78530

On Mon, Feb 14, 2011 at 4:27 PM, Ojan Vafai <ojan at chromium.org> wrote:

> This behavior did change. But ctrl was never involved. If you ever clicked
> on a line next to an existing review comment line, it would expand to
> include it. The problem is that it's then difficult to leave comments on
> adjacent lines.
>
> You can still click and drag to expand the context though as long as you
> start inside the existing context. Alternately, adding ctrl (shift is
> probably better) to expand the context wouldn't be a difficult addition.
>
> Ojan
>
>
> On Mon, Feb 14, 2011 at 4:01 PM, Antonio Gomes <tonikitoo at gmail.com>wrote:
>
>> Previously, I was able to increase the context of my inline review
>> comments by clicking on consecutive line numbers while pressing CONTROL. It
>> seems regressed. Am I the only one noticing that?
>>
>>
>> --
>>  --Antonio Gomes
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110215/a127b800/attachment.html>


More information about the webkit-dev mailing list