[webkit-dev] DocumentLoader::m_mainResourceData seems no need

[Pavel Feldman]

On Tue, Aug 16, 2011 at 11:20 AM, Xianzhu Wang <phnixwxz at gmail.com> wrote:

> Hi,
>
> I found that DocumentLoader will hold m_mainResourceData during its whole
> life. I'm wondering if this is necessary. I searched all callers of
> DocumentLoader::mainResourceData() and DocumentLoader::mainResource() and
> they seem all called before or just after the document is loaded.
>

This is not the case for the inspector and a number of other usages I can
see here:
http://codesearch.google.com/codesearch#search/&exact_package=chromium&q=mainResourceData%5C(%5C)&type=cs

"just after" might be problematic to define as well.

Regards
Pavel

If we remove DocumentLoader::m_mainResourceData, the main resource data
> could be freed if there is no other references (seems true if the page is
> not inspected) and will save memory.
>
> I tried to removing DocumentLoader::m_mainResourceData and run all layout
> tests in chromium-linux. I got 6 text mismatches and 1 timeout and will
> investigate the failures.
>
> However, can anyone describe the original intent of
> DocumentLoader::m_mainResourceData? What's the case that it is used after
> the document is loaded?
>
> Thanks,
> Xianzhu
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110816/d7815648/attachment.html>