[webkit-dev] new-run-webkit-tests new results.html format

[Ojan Vafai]

Thanks for the quick feedback.

On Thu, Apr 21, 2011 at 4:21 PM, Maciej Stachowiak <mjs at apple.com> wrote:

> (1) Takes two lines per entry unless you make your window ridiculously
> wide. This makes it hard to scan.
>

I'll make it whitespace:nowrap. That will mean the right side might get cut
off, but I think that's fine.


> (2) Slow to load (apparently it loads a 3 meg JSON file before displaying
> anything?)
>

Loading it locally is very fast for me. I guess I should try it on a laptop
though.

For context, we reuse the JSON file that's used for the test runtime
treemaps, which means we need an entry for each test. That json will will
get .5 meg smaller shortly. There are a number of approaches to make this
smaller if needed. Some options would be to generate a separate JSON file,
or to make the data format in the existing json file more compact.


> (3) I like PrettyPatch format better than wdiff format.
>

This is orthogonal. new-run-webkit-tests will use whichever one is available
on the system. The results.html file will display whichever one was used.


> (4) Blue text on a blue background is not great for legibility.
>

I'll change the blue background to #eee.


> (5) When running pixel tests, the animated image diffs are handy.
>

Oh right. I forgot about these. I'll think of something for this.


>
> (1) and (2) seem like the most serious regressions relative to ORWT.
>
> Regards,
> Maciej
>
>
> On Apr 21, 2011, at 2:11 PM, Ojan Vafai wrote:
>
>
> http://build.chromium.org/f/chromium/layout_test_results/Webkit_Linux_64/results/layout-test-results/results.htmlshows the latest run of Chromium's Linux 64 bot.
>
> Beware the expand all link with that many failures. It gets very slow.
>
> On Tue, Apr 19, 2011 at 2:36 PM, Eric Seidel <eric at webkit.org> wrote:
>
>> Would be nice to have a live demo to see all the new javascripty-ness.
>>  Do you have an example from a NRWT run on build.webkit.org or
>> build.chromium.org?
>>
>> Thanks for all your work on this, Ojan.
>>
>> -eric
>>
>> On Tue, Apr 19, 2011 at 2:29 PM, Ojan Vafai <ojan at chromium.org> wrote:
>> > As of r84294, new-run-webkit-tests's results.html has a new format.
>> > Non-chromium people, feel free to take a look and see if this addresses
>> your
>> > concerns in https://bugs.webkit.org/show_bug.cgi?id=37736. Chromium
>> people,
>> > if you encounter problems or have feature requests, please let me know
>> or
>> > file bugs.
>> >
>> > Some of the new features:
>> > -View actual/expected results inline.
>> > -View actual/expected/diff images at 3x zoom to better see what changed.
>> > -Control showing expected failures with a checkbox instead of a
>> commandline
>> > flag to new-run-webkit-tests.
>> > -Link to the httpd error logs.
>> > -Show failure type and expected failure type.
>> > Ojan
>> > _______________________________________________
>> > webkit-dev mailing list
>> > webkit-dev at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> >
>> >
>>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110421/2cace01f/attachment.html>