[webkit-dev] [webkit-changes] [83955] trunk

[Philippe Normand]

I think this rollout highlighted the need for crash reports in the GTK
Release bot. The issue being absent from the Debug bots, we had to build
WebKitGTK with debug symbols and optimizations turned on to get useful
stack-traces.

Oliver relanded the big patch with an additional workaround for a gcc
reordering bug that he found after a gdb-over-irc session with me, once
I managed to have a local build useful enough for debugging.

Philippe

On Fri, 2011-04-15 at 10:55 -0700, Adam Barth wrote:
> As everyone knows, I'm a proponent of rolling things out more
> frequently, but that change looks huge.  I think we should have a bias
> against rolling out large changes because they're much harder and
> disruptive to roll in and out than small changes.  (Of course, we
> should also have a bias against accepting large patches, but sometimes
> they're necessary, as I assume Oliver's change was.)
> 
> Adam
> 
> 
> On Fri, Apr 15, 2011 at 10:41 AM, Oliver Hunt <oliver at apple.com> wrote:
> > Indeed, i missed the gtk release one, but the point stands that just rolling out a patch (which should not roll out the changelogs) without providing any information about the crash doesn't help anyone.
> >
> > --Oliver
> >
> > On Apr 15, 2011, at 10:30 AM, Adam Roben wrote:
> >
> >> On Apr 15, 2011, at 1:19 PM, Oliver Hunt wrote:
> >>
> >>> Don't roll out patches that don't break any core builders, without making some attempt to diagnose the problem or providing information that will make it possible to fix the problem.
> >>
> >> The GTK bots are core builders.
> >>
> >> -Adam
> >>
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110417/0eb86736/attachment.bin>