[webkit-dev] Review tool changes

Ojan Vafai ojan at chromium.org
Thu Sep 16 18:25:23 PDT 2010


On Fri, Sep 17, 2010 at 10:33 AM, Darin Adler <darin at apple.com> wrote:

> 2) It’s kind of crazy that the review tool’s URL is
> "...&action=prettypatch". It was nice of you to leave the old review tool
> unchanged, at least in part to placate me, but you’re squatting on another
> feature’s territory! I think we want a plain old formatted diff for other
> purposes. We need to get your tool out of there!
>

What's crazy about this? What are the other uses of the plain formatted diff
that aren't met by this? I agree with the new tool replacing the old one. I
just don't see the benefits of keeping both the new review tool and the
formatted diff page.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100917/161552ea/attachment.html>


More information about the webkit-dev mailing list