[webkit-dev] Review tool changes

Darin Adler darin at apple.com
Thu Sep 16 17:33:27 PDT 2010


Hi Adam.

A few thoughts on the review tools on bugs.webkit.org.

    1) I am happy with the review tool. I have been using it for a lot of reviews. There may be no one left who prefers the old review page.

    2) It’s kind of crazy that the review tool’s URL is "...&action=prettypatch". It was nice of you to leave the old review tool unchanged, at least in part to placate me, but you’re squatting on another feature’s territory! I think we want a plain old formatted diff for other purposes. We need to get your tool out of there!

    3) I suggest you make your review tool the default at "...&action=review" and move the old style review tool to another URL; we can put a link in yours.

I haven’t tried to use it on an iPad yet.

    -- Darin



More information about the webkit-dev mailing list