[webkit-dev] Can node->renderer()->node() == node ever be false?

Adam Roben aroben at apple.com
Tue Sep 14 16:45:25 PDT 2010

On Sep 14, 2010, at 6:46 PM, Dimitri Glazkov wrote:

> I've been looking at this line here and it doesn't seem to make sense
> to me: http://trac.webkit.org/browser/trunk/WebCore/page/EventHandler.cpp#L2153
> It looks like the loop in question will always exit early, because it
> short-circuits to node->renderer()->node() == node, which seems like
> it always will be true. At least, that's what the layout tests say
> when I remove it.

I don't see anything in that loop that is equivalent to node->renderer()->node() == node. All I see are null-checks. Note that line 2154 declares a new variable with the name "node".

I don't know anything else about this code or what you're asking, though.


More information about the webkit-dev mailing list