[webkit-dev] New Rich Text Editing Test suite

Roland Steiner rolandsteiner at google.com
Sun Oct 3 23:07:10 PDT 2010

I don't have a ToT WebKit browser ATM, but I'll check once I updated and

FWIW, this seems to be a regression anyways, since release Chromium (Chrome
6.0) at least passes all those tests, without extra <br> (?)


- Roland

On Sat, Oct 2, 2010 at 5:07 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> However, we pass JustifyLeft, JustifyRight, JustifyCenter even though we
> also add BR in those cases.  I don't quite understand the difference
> there...
> - Ryosuke
> On Thu, Sep 30, 2010 at 6:58 PM, Roland Steiner <rolandsteiner at google.com>wrote:
>> On Fri, Oct 1, 2010 at 10:49 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>> Mn... I realized something strange here.
>>> RTE2-AC_JF_TEXT-1_SC fails on WebKit TOT and the test is: JustifyFull on
>>> "foo^bar".  However, it clearly works on WebKit when I test it manually.  It
>>> generates <div style="text-align: justify;">foobar<br></div>.  I'm not sure
>>> why the test claims that WebKit fails on this particular test.
>> That is probably one of the areas that needs discussion - the way the
>> suite is set up currently, it doesn't allow for "superfluous" HTML elements.
>> I.e., my guess is that it fails because of the extra <br> (ATM I don't have
>> a TOT WebKit browser, so can't confirm for sure). I have added cases like
>> this as "acceptable" (but not ideal) results for some tests, but not yet all
>> of them (if we want to add this, then I guess I should implement some
>> systematic way to check these rather than adding it by hand, though).
>> Cheers,
>> - Roland
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101004/256bc110/attachment.html>

More information about the webkit-dev mailing list