[webkit-dev] Why are the mock implementations in WebCore/platform?

Adam Barth abarth at webkit.org
Fri Nov 26 11:20:02 PST 2010

Originally, I thought it made sense to mock out pieces of the platform
abstraction that didn't exist in all ports (e.g., GPS sensors).  I'm
not sure why you'd want to mock out a client interface.  Can't you
just implement the client interface in DRT?


On Fri, Nov 26, 2010 at 10:33 AM, Sam Weinig <sam.weinig at gmail.com> wrote:
> Just a general question as to why the decision was made to put the mock
> implementation classes (DeviceOrientationClientMock, GeolocationServiceMock
> and SpeechInputClientMock) beneath WebCore/platform.  WebCore/platform is
> not supposed to know about classes outside of WebCore/platform in WebCore
> (such as DeviceOrientationController) and this seems to be perpetuating the
> laying violation.  Perhaps a top-level WebCore/mock/ would be preferable.
> - Sam
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list