[webkit-dev] Why are the mock implementations in WebCore/platform?

Jeremy Orlow jorlow at chromium.org
Fri Nov 26 10:42:24 PST 2010

Note that it's still a bit of an open question as to where mocks should live
in general. IIRC, the top candidates are like device orientation and speech
do now, somehow in some central place but not compiled into production
libraries, or in DRT (which means more copied code, but the platform layers
will be better exercised).

It would be nice to get this resolved once and for all and get the code
cleaned up.


On Fri, Nov 26, 2010 at 6:33 PM, Sam Weinig <sam.weinig at gmail.com> wrote:

> Just a general question as to why the decision was made to put the mock
> implementation classes (DeviceOrientationClientMock, GeolocationServiceMock
> and SpeechInputClientMock) beneath WebCore/platform.  WebCore/platform is
> not supposed to know about classes outside of WebCore/platform in WebCore
> (such as DeviceOrientationController) and this seems to be perpetuating the
> laying violation.  Perhaps a top-level WebCore/mock/ would be preferable.
> - Sam
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101126/27b097cf/attachment.html>

More information about the webkit-dev mailing list