[webkit-dev] Coding style change - Indentation of forward declarations in headers

[David Levin]

On Mon, Nov 1, 2010 at 10:06 AM, Brady Eidson <beidson at apple.com> wrote:

>
> On Nov 1, 2010, at 10:00 AM, David Hyatt wrote:
>
> Yeah I agree with Peter.  I think blank lines after { and before } would
> improve the readability of the 2nd example even without indentation.
>
> namespace WebCore {
>
> class AuthenticationChallenge;
> class CachedFrame;
> class HistoryItem;
> class ProtectionSpace;
> class ResourceLoader;
> class ResourceRequest;
>
> }
>
>
> I agree this also makes it more readable, but...
>
> This doesn't seem worth making a special case for to me.
>
>
> If the general sentiment is "I don't have a strong preference either way",
> then I would argue that we should allow its continued used simply because so
> much code already uses it.
>

On the other hand, less rules/exceptions = less mental clutter for me to
keep track of = easier for folks to get right, imo.

But I do believe that you are simply stating a rule that is already followed
and just not written, so while I prefer less rules/exception, I don't object
to this.

dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101101/33c1f1ef/attachment.html>