[webkit-dev] Yet another bug-less change hosed the tree.

David Kilzer ddkilzer at webkit.org
Wed May 12 08:53:50 PDT 2010

On Tue, May 11, 2010 at 2:30:45 PM, Geoffrey Garen wrote:

> I don't know how to do either of these steps in an easy way:
> 1. Once I have a patch with a ChangeLog, say, "File a new 
> bug and upload this patch for review." (Bonus points if the
> tool automatically made the first line of the ChangeLog the
> title of the bug.)

The little-known, little-used "webkit-patch create-bug" command does this today with the "--no-prompt" switch.  However, you can't limit it to a single directory for svn (like other webkit-patch commands), you can't give it a patch file to upload (interesting idea), and it's probably only been tested (by me) with git.

The "webkit-patch upload" command is the preferred alternative, although it still doesn't have a way to make the first line of the ChangeLog the title of the bug (which is the main reason I haven't switched to using it), and it has over 3x the number of command-line switches as create-bug.  (I must read through the switches for any webkit-patch subcommand because I don't use it frequently enough to remember them.)

> 2. Once the patch has been reviewed, say, "Add bug # and
> reviewer information from Bugzilla, commit, and close the
> bug." (Bonus points if the commit happens via the bugzilla 
> patch, so I can move on to working on another patch.)

My initial thought for doing this was to provide a placeholder (like "http://webkit.org/b/00000") with prepare-ChangeLog so that webkit-patch could update it at the right time, just like it does with the reviewer.

Another approach would be to write a rule that adds the bug number at a particular location in the ChangeLog each time--as long as it was smart enough not to duplicate bug links if one was already present.


More information about the webkit-dev mailing list