[webkit-dev] New in-rietveld patch flag

Julie Parent jparent+webkit at gmail.com
Mon May 10 20:24:54 PDT 2010


I'm pretty sure we can modify the template to just hide that one particular
flag.  I'll look into it tomorrow.

Julie

On Mon, May 10, 2010 at 8:23 PM, Eric Seidel <eric at webkit.org> wrote:

> I have made the flag inactive.  it was driving my poor little eyes
> bonkers.  I will work with Julie/Ojan on some less UI-hateful
> solution.
>
> -eric
>
> On Mon, May 10, 2010 at 4:46 PM, Eric Seidel <eric at webkit.org> wrote:
> > There is an "is Active" checkbox, which I could uncheck:
> > https://bugs.webkit.org/editflagtypes.cgi?action=edit&id=4
> >
> > I'm not sure how the tools would be able to set this flag if I did that.
> >
> > We could also hack the various UI to hide the flag?
> >
> > -eric
> >
> > On Mon, May 10, 2010 at 4:41 PM, Adam Barth <abarth at webkit.org> wrote:
> >> Can we hide this in the UI?  My understanding is that it will be used
> >> only by the tools.
> >>
> >> Adam
> >>
> >>
> >> On Mon, May 10, 2010 at 4:37 PM, Eric Seidel <eric at webkit.org> wrote:
> >>> As part of https://bugs.webkit.org/show_bug.cgi?id=38866 I've added a
> >>> new flag to bugzilla patches called "in-rietveld".
> >>>
> >>> This flag may be changed or removed in the coming weeks.  If you have
> >>> questions/comments/concerns please bring them up with Ojan or Julie on
> >>> the bug.
> >>>
> >>> Thanks to both of them for doing the leg-work to try and improve our
> >>> reviewing experience!
> >>>
> >>> -eric
> >>> _______________________________________________
> >>> webkit-dev mailing list
> >>> webkit-dev at lists.webkit.org
> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >>>
> >>
> >
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100510/edf277d1/attachment.html>


More information about the webkit-dev mailing list