[webkit-dev] Help with review of EFL CMake patches?

Patrick Roland Gansterer paroga at paroga.com
Mon May 3 14:09:11 PDT 2010


On Mon, 3 May 2010 17:33:45 -0300, Gustavo Sverzut Barbieri
<barbieri at profusion.mobi> wrote:
> Did you see this new version?  Leandro did the work on top of yours.
> However he removed the .h from the source list, he did it before he
> read that it may be useful to get some IDE to show it. If mandatory we
> can add them back.
Yes, I've seen it. He did a great job, but there a some parts which are
not good for a "general buildsystem".
E.g. INCLUDE(Options${PORT}) doesn't support different ports well, since
ports share some parts. (There some other points too; I'll post them on the

My vision is that the root CMake file will do all the "WTF_USE_*" stuff.
It has to decide all "port specific stuff". All other CMake files should
only use this "defines". This will provide a central to switch the
different implementations (e.g. switch between pthread and native threads
on windows).
I already run in some problem with my JavaScriptCore CMake files, but I
hoped for some feedback I didn't get.

My big question is if CMake should be added as a universal buildsystem (to
get rid of some other buildsystems) or if it is only for the EFL port?
I think this depends on ther progress in the CMake vs. GYP discussion. The
last post on the mailing list was [1].

- Patrick

[1] https://lists.webkit.org/pipermail/webkit-dev/2010-April/012662.html

More information about the webkit-dev mailing list