[webkit-dev] Yet another email about a broken tree

[Kenneth Russell]

On Wed, Mar 17, 2010 at 12:44 AM, Maciej Stachowiak <mjs at apple.com> wrote:
>
> On Mar 17, 2010, at 12:02 AM, Adam Barth wrote:
>
>>
>> Manual investigation seems to implicate
>> <http://trac.webkit.org/changeset/56074> for at least some of the
>> brokenness in SnowLeopard Intel Release (Tests).  There's a patch in
>> <https://bugs.webkit.org/show_bug.cgi?id=36194> that claims to fix
>> things, but the brokenness has been polluting the tree for 12 hours.
>> Is there some reason we didn't roll out the offending patch?
>
> Kenneth intended to temporarily disable the failing tests:
> <http://trac.webkit.org/changeset/56093>. That seems to have cleaned up the
> failures on other bots, but there is still a great number of failures on
> SnowLeopard release.  I'm not sure what we can do other than revert the
> patch until the correct fix is ready.

I apologize for the widespread WebGL test breakage from this patch. I
sidestepped the commit queue because other broken tests had blocked
it, and this patch was blocking other work. While the patch worked
fine on our local machines (both Leopard and Snow Leopard), it seems
that OpenGL driver bugs on the build bots caused many tests to fail,
in particular on the Snow Leopard bot. This afternoon we skipped the
tests that were blocking the bots the cq cared about.

Mo worked as quickly as possible today to come up with a workaround
for the broken drivers, and a patch is out for review, but perhaps the
original patch should be rolled out after all, and a revised version
re-committed through the queue.

Again, I apologize for the breakage. It would be best for everyone, I
think, if we got the tree to a green state and all committed through
the queue, thereby having a line of defense against unexpected test
failures on the bots.

-Ken

>> Manual investigation confirms <http://trac.webkit.org/changeset/56079>
>> broke GTK Linux 32-bit Release, GTK Linux 64-bit Release, and Qt Linux
>> Release.  Is there some reason we didn't roll out the offending patch?
>
> It seems like the problem is just that Linux ports are failing the new test
> cases added by that patch. The actual code changes only affect the Mac port.
> I think the appropriate action would be to skip the two new tests and/or
> land platform-specific results on platforms where they are failing.
>
> Regards,
> Maciej
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>