[webkit-dev] Yet another email about a broken tree

[Maciej Stachowiak]

On Mar 17, 2010, at 12:02 AM, Adam Barth wrote:

>
> Manual investigation seems to implicate
> <http://trac.webkit.org/changeset/56074> for at least some of the
> brokenness in SnowLeopard Intel Release (Tests).  There's a patch in
> <https://bugs.webkit.org/show_bug.cgi?id=36194> that claims to fix
> things, but the brokenness has been polluting the tree for 12 hours.
> Is there some reason we didn't roll out the offending patch?

Kenneth intended to temporarily disable the failing tests: <http://trac.webkit.org/changeset/56093 
 >. That seems to have cleaned up the failures on other bots, but  
there is still a great number of failures on SnowLeopard release.  I'm  
not sure what we can do other than revert the patch until the correct  
fix is ready.



>
> Manual investigation confirms <http://trac.webkit.org/changeset/56079>
> broke GTK Linux 32-bit Release, GTK Linux 64-bit Release, and Qt Linux
> Release.  Is there some reason we didn't roll out the offending patch?

It seems like the problem is just that Linux ports are failing the new  
test cases added by that patch. The actual code changes only affect  
the Mac port. I think the appropriate action would be to skip the two  
new tests and/or land platform-specific results on platforms where  
they are failing.

Regards,
Maciej