[webkit-dev] Patches saying “Unreviewed”

Eric Seidel eric at webkit.org
Fri Jul 30 13:49:28 PDT 2010

This was added to enable a sane "you filled in a reviewer" check.
Requiring patch submitters to be explicit that the patch was not
reviewed instead of the case where they got the reviewer information

We *very* commonly have cases where contributors (especially new ones)
just delete the "Reviewed by" line, or fill it in with "Reviewed by
nobody." or similar.  Not understanding our (admittedly confusing)

I'm definitely open to other/better solutions.  Including removing (at
least the "unreviewed" part of) the check when not in commit-queue


On Fri, Jul 30, 2010 at 4:23 PM, Adam Barth <abarth at webkit.org> wrote:
> On Fri, Jul 30, 2010 at 1:10 PM, Darin Adler <darin at apple.com> wrote:
>> It’s come to my attention that some webkit-patch or some other script requires that patches without review contain the string “Unreviewed” somewhere in their change log message. I personally think this is not helpful. In my opinion patches that are don’t need review, such as some simple build fixes, need not list a reviewer, but also need not call attention to that fact.
> The commit-queue requires something like that to make sure it succeeds
> in filling in the reviewer information from bugs.webkit.org.  Running
> webkit-patch on the command line shouldn't require that.  We can
> figure out another mechanism to make sure the commit-queue fills in
> the proper reviewer.
> Adam
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list