[webkit-dev] Patches saying “Unreviewed”

Adam Barth abarth at webkit.org
Fri Jul 30 13:23:27 PDT 2010

On Fri, Jul 30, 2010 at 1:10 PM, Darin Adler <darin at apple.com> wrote:
> It’s come to my attention that some webkit-patch or some other script requires that patches without review contain the string “Unreviewed” somewhere in their change log message. I personally think this is not helpful. In my opinion patches that are don’t need review, such as some simple build fixes, need not list a reviewer, but also need not call attention to that fact.

The commit-queue requires something like that to make sure it succeeds
in filling in the reviewer information from bugs.webkit.org.  Running
webkit-patch on the command line shouldn't require that.  We can
figure out another mechanism to make sure the commit-queue fills in
the proper reviewer.


More information about the webkit-dev mailing list