[webkit-dev] More thoughts on cleaning up the root directory

Maciej Stachowiak mjs at apple.com
Mon Dec 27 19:13:23 PST 2010

On Dec 27, 2010, at 12:04 AM, Adam Barth wrote:

> Here's a snapshot of my current thinking on where the files and
> folders currently in the top-level directory might go.
> There are a bunch of build-system related files that are currently in
> the root.  I'm not sure whether we should leave them in there or move
> them into Sources somewhere.  I'm tempted to put them into Sources so
> that Sources is self-contained package of all the stuff you need to
> build WebKit.  That said, having a top-level Makefile that kicks off
> the whole process also seems reasonable.
> Examples/
> PerformanceTests/
>  PageLoad/ (was PageLoadTests)
>  SunSpider/
>  HTMLParser/ (was WebCore/benchmarks/parser)
> RegressionTests/ (was LayoutTests)
>  manual/ (was WebCore/manual-tests)

I would suggest putting manual/ under a separate directory, to reduce potential confusion from having content in there that is not run automated.

Also, perhaps JavaScriptCore/tests should be moved out of JavaScriptCore.

> Sources/
>  automake/
>  cmake/
>  JavaScriptCore/
>  JavaScriptGlue/
>  Platform/ (was WebCore/platform)
>  WebCore/
>  WebKit/
>  WebKit2/
>  WTF/ (was JavaScriptCore/wtf)
>  ThirdParty/
>    ANGLE/
>    + Contents WebKitLibraries
> Tools/
> Websites/
> .gitattributes
> .gitignore
> ChangeLog
> Makefile
> Makefile.shared
> == UNSURE ==
> autogen.sh
> Android.mk
> common.pri
> cmakeconfig.h.cmake
> CMakeLists.txt
> configure.ac
> GNUmakefile.am
> wscript
> DerivedSources.pro
> WebKit.pri
> WebKit.pro

I think it would be fine to leave any build files at top level that are necessary to build any given port with a conventional build command at top level. Otherwise move to subdirectories. I don't know which ones this is true for.


More information about the webkit-dev mailing list