[webkit-dev] Platform specific fields on WebCore::HistoryItem

[Brady Eidson]

On Dec 21, 2010, at 11:39 AM, Darin Fisher wrote:

> I'm working on fixing some session history bugs related to a HistoryItem's URL property changing.
> See for example the call to HistoryItem::setURL in HistoryController::updateForReload [1].
> 
> I'm curious about the platform specific fields on WebCore::HistoryItem.  *** Do any of those need to
> be updated when the URL of the HistoryItem changes? ***
> 
> Here are the fields I'm referring to:
> 
> class HistoryItem ... {
> private:
>     ...
> #if PLATFORM(MAC)
>     RetainPtr<id> m_viewState;

This is used for the Page Cache only.  The URL had sure better not change while the page is cached!

>     OwnPtr<HashMap<String, RetainPtr<id> > > m_transientProperties;

This is to support arbitrary WebKit Mac API and has nothing to do with the URL identity of the item.

~Brady

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101221/a08fca4b/attachment.html>