[webkit-dev] Bad Qt API?

[Kenneth Rohde Christiansen]

Btw, Eric,

We have unit tests for the QWebElement API in
WebKit/qt/tests/qwebelement/ so you can see the use-cases, if that
helps.

Cheers,
Kenneth

On Wed, Aug 25, 2010 at 3:58 PM, Kenneth Rohde Christiansen
<kenneth.christiansen at gmail.com> wrote:
> They are methods for manipulating the DOM, modelled after jQuery. The
> documentation should explain pretty well what they do.
>
> Is it possible to accomplish the same behaviour with the new parser
> API? We need to continue supporting this API due to our binary
> compatibility, plus because of the fact that it was added due to
> customer request.
>
> Cheers,
> Kenneth
>
> On Wed, Aug 25, 2010 at 3:46 PM, Eric Seidel <eric at webkit.org> wrote:
>> /*!
>>    Encloses the contents of this element with the result of parsing \a markup.
>>    This element becomes the child of the deepest descendant within \a markup.
>>
>>    \sa encloseWith()
>> */
>> void QWebElement::encloseContentsWith(const QString &markup)
>>
>>
>> http://trac.webkit.org/browser/trunk/WebKit/qt/Api/qwebelement.cpp#L1248
>>
>> These enclose methods use at least 2 deprecated parts of parser code
>> (HTMLElement::endTagRequirement() and
>> HTMLElement::deprecatedCreateContextualFragment()).
>>
>> They're clear layering violations, and make little sense to me.
>>
>> Who wants to call this API?  Can it be removed from Qt?
>>
>> -eric
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
>
> --
> Kenneth Rohde Christiansen
> Technical Lead / Senior Software Engineer
> Qt Labs Americas, Nokia Technology Institute, INdT
> Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
>
> http://codeposts.blogspot.com ﹆﹆﹆
>



-- 
Kenneth Rohde Christiansen
Technical Lead / Senior Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone  +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org

http://codeposts.blogspot.com ﹆﹆﹆