[webkit-dev] Testing changes to CodeGenerator*.pm
abarth at webkit.org
Thu Apr 29 10:32:20 PDT 2010
On Thu, Apr 29, 2010 at 9:44 AM, Alexey Proskuryakov <ap at webkit.org> wrote:
> On 26.04.2010, at 22:06, Adam Barth wrote:
>> If you make changes to CodeGenerator*.pm, please test your
>> change using the following command:
>> ~/git/webkit$ ./WebKitTools/Scripts/run-bindings-tests
> I don't understand the utility of such testing. When one edits
> CodeGenerator*.pm, that's generally to change its output, so
> run-bindings-tests tests will of course fail.
> It's great to test end-to-end behavior, and unit tests can also also useful
> sometimes, but why test that source code stays byte to byte identical?
I should say that there's also a class of changes to CodeGenerator*.pm
where we don't want to change its output at all. For example,
removing some of the ridiculously deeply nested if statements.
More information about the webkit-dev