[webkit-dev] Implementing the sizes attribute of the link tag from HTML5

Stephan Assmus superstippi at gmx.de
Tue Apr 20 10:48:35 PDT 2010


Darin Adler wrote:
> On Apr 15, 2010, at 3:41 PM, Aaron Boodman wrote:
> > On Thu, Apr 15, 2010 at 3:25 PM, Maciej Stachowiak <mjs at apple.com>
> wrote:
> >> Well, it's hard to truly have consensus on adding feature without
> knowing what it is. That being said, I at least would love to see a more
> specific proposal for what we could do with <link size>.
> > 
> > I want to support bigger icons for the tabs in Chromium.
> > 
> > I'm not sure what the path is for fetching favicons today.
> To load an icon you call retainIconForPageURL and then later call
> iconForPageURL once the icon is loaded. The iconForPageURL function takes an
> IntSize.
> But if you look at IconRecord.cpp you will see that at the moment the size
> isn’t yet used.

Indeed. The method can return a BitmapImage instance, which may contain several bitmaps of different size. In the Haiku port, I've temporarily made some useful BitmapImage methods public, to iterate over all images contained in the object and find the one with the size I want (in the browser code later on). Is there a better way to do this? How do other browser projects handle this? Would a patch to make some BitmapImage methods public have good chances of being accepted or is there another vision?

Best regards,

More information about the webkit-dev mailing list