[webkit-dev] Please do not commit-queue+ changes to ChromiumBridge.h
darin at chromium.org
Sat Sep 5 07:16:14 PDT 2009
That's why I started this thread. The process may be a bit unfamiliar to
somepatch contributors (especially new ones), and so I wanted reviewers to
the know that changes to ChromiumBridge.h should not be committed using
the commit queue.
On Sat, Sep 5, 2009 at 1:45 AM, Eric Seidel <eric at webkit.org> wrote:
> Agreed. It's the submitters responsibility to make it clear that they
> don't want their patch committed immediately after review. Current
> assumption is that all committers don't want their patches committed after
> review, but all non-committers do.
> On Fri, Sep 4, 2009 at 7:12 PM, David Levin <levin at chromium.org> wrote:
>> Even better if the person submitting the patch marks it as commit-queue-
>> when they do the r? (as Jian does for example) to prevent this from
>> Just do this for any patch that you want to be in control of landing.
>> On Fri, Sep 4, 2009 at 11:04 AM, Darin Fisher <darin at chromium.org> wrote:
>>> Please do not commit-queue+ changes to ChromiumBridge.h
>>> These changes by definition break the Chromium build because they require
>>> corresponding changes in the Chromium repository. Please leave such CLs to a
>>> Chromium developer to commit because they can then coordinate the landing of
>>> the other side of the patch.
>>> Also, if you are wondering about the impact of a WebKit patch on the
>>> Chromium build, please see our integration bots here:
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev