[webkit-dev] Calling all committers: The pending-commit list is overflowing

Adam Barth abarth at webkit.org
Mon Oct 19 21:56:44 PDT 2009

On Mon, Oct 19, 2009 at 8:54 PM, Adam Barth <abarth at webkit.org> wrote:
> On Mon, Oct 19, 2009 at 8:39 PM, David Kilzer <ddkilzer at webkit.org> wrote:
>> Why are there 17 patches with review+ that never get landed?
>> This has bothered me in the past, but I wasn't sure if it was the same group of patches or not.
> It's not the same group of patches.  Sometimes there are patches with
> review+ but with comments that need to be addressed by the
> contributor.  Other times, there are dependent patches that haven't
> been landed.  We could be more agressive in clearing out the
> pending-commit list, but it only seems problematic when it piles up.

As an experiment, I went through this list in detail and brought it
down to 11 patches.  The rest fall into the following categories:

1) Epic uber bugs that are incomprehensible.  For example:


2) Apple contributors who have explicitly asked not to have their
patches landed for them, for whatever reason.  For example:


3) Patches where the patch has been review+ but the contributor has
been asked to consider non-trivial (meaning I can't do it for them)
changes.  For example:


I don't see a big need to drive this list all the way to zero.  If we
could get the review queue down to 11 patches, I'd be a really happy
man.  :)


More information about the webkit-dev mailing list