[webkit-dev] Landing your own patches

Adam Barth abarth at webkit.org
Wed Oct 14 00:38:42 PDT 2009

Has this actually been a problem?  I know the commit-queue broke
something today when landing a patch for Evan Martin, but he was on
IRC and I made sure he was on the hook to watch the bots before I had
to leave.  If I've landed things via commit-queue and not cleaned up
after them, I certainly apologize.  Eric has talked about having the
commit-queue watch the bots and send out email to the appropriate
people when the commit-queue breaks something.

What I see as more of a problem is the failing tests on Tiger and
SnowLeopard the past few days.  Having red columns on the tree makes
it harder to see when a new regression is introduced.  Looking at the
tree, the issue seems to have been resolved.  If that was caused by
the commit-queue, then I agree we should improve the commit-queue
process.  If it was caused by someone committing their own patch, then
I think we should improve the self-commit process.


On Tue, Oct 13, 2009 at 11:22 PM, Sam Weinig <sam.weinig at gmail.com> wrote:
> Hi WebKit Developers,
> As nice as it may be to have a bot landing your patches, I think developers
> who have a commit bit should try and make the effort to land their own
> patches.  Mainly I think this is a good idea since the creator of the patch
> has a much better chance of fixing the issue or quickly rolling it out if
> they have to consciously commit and watch the bots.  It also, and perhaps
> more importantly, places a lesser burden on the community who ends up doing
> this job for them.
> I understand the concern of those working on Windows who don't necessarily
> have access to a Mac and I applaud your fear of breaking the build, but I
> think in the end you are using the wrong tool (admittedly due to a lack of
> trybots, but the commit bot will not run Qt or Gtk) and you are using it too
> much (most patches probably won't break a build, unless you are named Dave
> Hyatt).
> Thanks,
> -Sam
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list