[webkit-dev] Adding a "load type" that specifically does not touch session and global history

Adam Barth abarth at webkit.org
Tue Oct 13 08:27:17 PDT 2009


There's a notion of "lockHistory" in FrameLoader.  Is that related to
what you mean?  I haven't studied load type yet.

Adam


On Tue, Oct 13, 2009 at 8:22 AM, tonikitoo (Antonio Gomes)
<tonikitoo at gmail.com> wrote:
> Adam, something else that imho must be considered ( while refactoring
> the state machine ) is adding a "load type" that specifically does not
> touch session and global history, and avoid "abusing" some of the
> existent load types like below:
>
> <abuse>
>    // FIXME: This seems like a dangerous overloading of the meaning
> of "FrameLoadTypeReload" ...
>    // shouldn't a more explicit type of reload be defined, that means roughly
>    // "load without affecting history" ?
>    if (shouldReloadToHandleUnreachableURL(newDocumentLoader)) {
>        ASSERT(type == FrameLoadTypeStandard);
>        type = FrameLoadTypeReload;
>    }
> </abuse>
>
>
> great effort so far , btw
>
> --
> --Antonio Gomes
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>


More information about the webkit-dev mailing list