[webkit-dev] FrameLoader cleanup

tonikitoo (Antonio Gomes) tonikitoo at gmail.com
Tue Oct 13 08:22:41 PDT 2009

Adam, something else that imho must be considered ( while refactoring
the state machine ) is adding a "load type" that specifically does not
touch session and global history, and avoid "abusing" some of the
existent load types like below:

    // FIXME: This seems like a dangerous overloading of the meaning
of "FrameLoadTypeReload" ...
    // shouldn't a more explicit type of reload be defined, that means roughly
    // "load without affecting history" ?
    if (shouldReloadToHandleUnreachableURL(newDocumentLoader)) {
        ASSERT(type == FrameLoadTypeStandard);
        type = FrameLoadTypeReload;

great effort so far , btw

--Antonio Gomes

More information about the webkit-dev mailing list