[webkit-dev] A bot-filled future?

Mark Rowe mrowe at apple.com
Thu Nov 12 13:04:40 PST 2009


On 2009-11-12, at 11:37, Adam Barth wrote:

> 1) Contributor posts patch for review.
> 2) Committer marks patch with the try? flag.
> 3) The try-queue downloads, applies, builds, and tests the patch.
> 4) If all systems are go, the try-queue marks the patch as try+.
> Otherwise, it marks the patch as try- with an explanation of what went
> wrong.

I have a few comments / questions about this:
1) People are already confused about how to handle the recently-added commit-queue flag.  Adding an extra flag is going to increase the confusion.
2) What machines are going to be doing these tests, and on which platforms?
3) Which patches would this test?  Running tests on an arbitrary patch uploaded in Bugzilla opens up the testing machine to executing arbitrary code unless there are limitations in place.

- Mark

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3166 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20091112/3e86d3e9/attachment.bin>


More information about the webkit-dev mailing list