[webkit-dev] Layering weirdness in chrome tree

Adam Barth abarth at webkit.org
Tue Nov 10 12:02:49 PST 2009

That sounds like a bug to me.  Historically the chromium port hasn't
had a strong distinction between WebKit and WebCore/platform, but I
think it's a worthwhile distinction to make.


On Tue, Nov 10, 2009 at 11:53 AM, Oliver Hunt <oliver at apple.com> wrote:
> I just noticed that there are a bunch of WebCore platform implementations
> being landed in Chrome's WebKit API rather than in WebCore/platform.  This
> seems incorrect to me as there is no other place where this sort of
> mis-layering occurred, the obvious files that stand out are:
> ApplicationCacheHost.cpp
> GraphicsContext3D.cpp
> MediaPlayerPrivateChromium.cpp
> PlatformMessagePortChannel.*
> ResoureHandle.cpp
> DOMUtilitiesPrivate.*
> I see no obvious reason for these being placed in WebKit -- as far as I can
> tell these represent a layering violation: it's not possible to build the
> WebCore directory into it's own library due to the hard dependency on the
> chrome webkit 'api'.
> --Oliver
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list