[webkit-dev] Review Queue

[Maciej Stachowiak]

On May 21, 2009, at 9:10 PM, Peter Kasting wrote:

> On Thu, May 21, 2009 at 8:52 PM, Eric Seidel <eric at webkit.org> wrote:
> Our current defacto policy requires involvement on both sides.
> Submitters need to be involved in finding people to review their
> patches.  Posting patches to the review queue does not automatically
> get you a review, except occasionally by Darin Adler or myself.
>
> FWIW, I've always been told that WebKit etiquette is to not choose a  
> reviewer (even when you know who would be good) and just mark a  
> patch r?.  (This is a stark contrast to the Mozilla way of _always_  
> selecting a reviewer.)
>
> It would probably be good to clarify this kind of thing.

It's better not to explicitly select a reviewer, since almost always  
there will be several people qualified. However, it is totally OK to  
ask a specific person if they would consider reviewing out of band of  
the bug system, or to Cc possible qualified reviewers on the bug.

Regards,
Maciej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090521/cb7a8bba/attachment.html>