[webkit-dev] Fwd: Review queue needs love

[Dimitri Glazkov]

I think this is a great way to distinguish bugs. I just posted on
chromium-dev recommending this.

:DG<

On Fri, Jun 19, 2009 at 11:46 AM, Maciej Stachowiak<mjs at apple.com> wrote:
>
> On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote:
>
> I absolutely understand that there are ways to proactively find reviewers,
> and I'm *not* complaining about the time being taken (I understand the
> constraints that most of the webkit reviewers have been under the last few
> weeks with WWDC, etc). As you say, we can always ping people on IRC to find
> reviewers for bugfixes.
> I was more specifically wondering if there was something about this patch
> that made it not show up on the list Eric provided below. My concern is
> because the bugfix came from a google.com address, it might have been
> getting lumped in with the "oh, must be Yet Another Chromium Patch so I
> won't worry about it" list, which if true has troubling implications given
> that there are an increasing number of Googlers that are making
> contributions to WebKit that have nothing to do with Chromium.
>
> I try to tag Chromium-specific bugs with [Chromium] in the bug title when I
> go through the review queue, and I know others do as well, so from the fact
> that this bug is not so tagged you can assume we are aware it is a
> cross-platform fix.
>  - Maciej
>
> -atw
>
> On Fri, Jun 19, 2009 at 10:51 AM, David Levin <levin at google.com> wrote:
>>
>> Drew, if you go to http://nightly.webkit.org/start/, then click "Patches
>> awaiting Review".
>> That is the list folks work off of, but it doesn't hurt to figure out the
>> appropriate person to review the patch (find out who has changed the file a
>> lot) and ping them in irc to see if they can get to it.
>> Dave
>>
>> On Fri, Jun 19, 2009 at 10:21 AM, Drew Wilson <atwilson at google.com> wrote:
>>>
>>> I note that this bug fix:
>>> https://bugs.webkit.org/show_bug.cgi?id=23721
>>> ...was not on the list below, and has been waiting for some reviewer love
>>> for a couple of weeks now. Is it falling through the cracks somehow?
>>> -atw
>>>
>>> On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu <andreip at google.com>
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel<eric at webkit.org> wrote:
>>>> >
>>>> > The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
>>>> > patches, and a bunch of huge new feature patches.
>>>> >
>>>>
>>>> No quite. The following two are rather small patches to common code
>>>> (appcache and database):
>>>>
>>>> https://bugs.webkit.org/show_bug.cgi?id=22700
>>>> https://bugs.webkit.org/show_bug.cgi?id=25711
>>>>
>>>> I think Alexey promised to look at them.
>>>>
>>>> Thanks,
>>>> Andrei
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev at lists.webkit.org
>>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>