[webkit-dev] webkit #16401

Luke Kenneth Casson Leighton lkcl at lkcl.net
Tue Jun 9 02:30:52 PDT 2009

>  (test2:9403): GLib-GObject-WARNING **:
>  /build/buildd/glib2.0-2.18.4/gobject/gsignal.c:3075: signal name
>  `browser-event::click' is invalid for instance `0xcf3b70'
>  so - yeah, whoops, something wrong there.  not surprising, because
>  this area of functionality (event handling) has changed.
>  i'll be looking at it today, find out what's going on.

 ah _ha_.  GdomEventTargetNode used to be a custom-written base class
which has now been removed, because the virtual base class
EventTargetNode has been merged into Node.  when GdomEventTargetNode
went belly-up, so did the browser-event handling.  whoops!

 i'll try adding it to Node and see what happens.

$ git diff
diff --git a/WebCore/bindings/scripts/CodeGeneratorGObject.pm b/WebCore/bindings
index 17200d2..1f2eafa 100644
--- a/WebCore/bindings/scripts/CodeGeneratorGObject.pm
+++ b/WebCore/bindings/scripts/CodeGeneratorGObject.pm
@@ -980,6 +980,7 @@ EOF
     my $txt_install_signals = "";

     if ($interfaceName eq "DOMWindow" or
+        $interfaceName eq "Node" or
         $interfaceName eq "XMLHttpRequest") {
         $txt_install_signals = << "EOF";
     event_signals[BROWSER_EVENT] = g_signal_new("browser-event",

More information about the webkit-dev mailing list