[webkit-dev] gdom_x_path_evaluator_create_ns_resolver [was: webkit #16401]

[Leon Winter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Luke Kenneth Casson Leighton wrote:
>> from a random google search, leading to this:
>>  http://www.faqts.com/knowledge_base/view.phtml/aid/34022
>>
>>  a code snippet is this:
>>
>>  // test with no prefix doesn't find nodes:
>>  var xpathResult = xmlDocument.evaluate(
>>   "//element",
>>   xmlDocument,
>>   null,
>>   XPathResult.ORDERED_NODE_SNAPSHOT_TYPE,
>>   null
>>  );
>>
>>  showing that yes, it should be possible to pass in NULL as that last
argument.
>>
>>  hmmm, ok, gimme 1 sec, i'll just update CodeGeneratorGObject.pm so it
>>  can accept NULL arguments and pass them on...
>
>  ok - try a git pull from http://github.org/lkcl/webkit/16401.master -
> i've disabled the g_return_val_if_fail() macros so that NULL can be
> passed in to all arguments - if you get a segfault somewhere in WebKit
> "core" code, you know you shouldn't have passed in one of the
> arguments as NULL :)
>
>  try this:
>   res = gdom_document_evaluate(doc, exp, GDOM_NODE(body), resolver, 0,
NULL);
>  or even this:
>   res = gdom_document_evaluate(doc, exp, NULL, resolver, 0, NULL);
>
>  l.
Just grabbed the latest git.
make complains about that:

ar: DerivedSources/.libs/JSCSSCharsetRule.o: No such file or directory
make[1]: *** [libWebCoreJS.la] Fehler 1
make[1]: *** Warte auf noch nicht beendete Prozesse...
WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
In function ‘NPError webkit_test_plugin_get_value(NPP_t*, NPPVariable,
void*)’:
WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:265:
warning: deprecated conversion from string constant to ‘char*’
WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:268:
warning: deprecated conversion from string constant to ‘char*’
WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
In function ‘char* NP_GetMIMEDescription()’:
WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:304:
warning: deprecated conversion from string constant to ‘char*’
mv -f
WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/.deps/TestNetscapePlugin_libtestnetscapeplugin_la-TestNetscapePlugin.Tpo
WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/.deps/TestNetscapePlugin_libtestnetscapeplugin_la-TestNetscapePlugin.Plo
make[1]: Leaving directory `/home/leon/builds/webkit_dom/webkit'
make: *** [all] Fehler 2

Regards,
Leon Winter
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkotgbQACgkQ3qn9m9SfDYdh8gCgn6k7Gf7K8VuUbP3F3pVHORTN
nP4AoM2wfClNJ9HvWnE1ohq6nJYTeMhQ
=FcIs
-----END PGP SIGNATURE-----