[webkit-dev] ExecState::thisObject()

Geoffrey Garen ggaren at apple.com
Mon Jul 13 14:25:32 PDT 2009

> 1.  Pass a "current global object" through to all toJS calls (lots of
> callsites changed)
> 2.  Store a "current global object" off of the ExecState (set by the
> JS engine before leaving into custom native code for property lookup
> or function execution).

> I discussed this a bit with Darin and Geoff, and we came to the  
> conclusion that the correct fix is to have each JS DOMObject store a  
> JSGlobalObject pointer and augment the toJS methods to pass a global  
> object instead of an ExecState (close to you #1).  I would not  
> advocate storing more data on the ExecState.

To add to what Sam just said, I don't think #2 is viable. Where would  
the JS engine get the "current global object" from?


More information about the webkit-dev mailing list