[webkit-dev] Show more context in diffs

Maciej Stachowiak mjs at apple.com
Thu Jul 2 16:37:21 PDT 2009

On Jul 2, 2009, at 4:33 PM, Julie Parent wrote:

> When viewing patches on bugs.webkit.org, either with the review tool  
> or prettydiff, I regularly find the 3 lines of context provided to  
> be insufficient to really understand the code change.  This may be  
> because I am new to the code base, or because I am used to review  
> tools like Rietveld, but I find that every time I want to look at a  
> patch, I have to open the file side by side with the patch window to  
> fully understand the change.  This is very annoying and often leads  
> me to just give up and not bother fully understanding the code.
> Proposal: I'd like to change svn-create-patch to increase the number  
> of lines of context provided (suggestions for how many are  
> welcome).  One downside to doing this of course would be that patch  
> sizes would increase.

I don't think it's just because you're (relatively) new. I often wish  
for more context myself.

  - Maciej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090702/83167d7c/attachment.html>

More information about the webkit-dev mailing list