[webkit-dev] namespace indent

David Levin levin at google.com
Thu Dec 3 15:40:12 PST 2009


btw, that you put it this way :) This issue came up before:

> First, it seems like the original motive was to avoid pointlessly
indenting nearly the whole file:
>
> https://lists.webkit.org/pipermail/webkit-dev/2009-September/010002.html
>
> So, I was wondering if we can clarify the rule to apply only to the
outermost namespace declaration.

>
> So, I was wondering if we can clarify the rule to apply only to the
outermost namespace declaration.

[Darin Adler's reply] Yes, I think we can.


So far it seems at least two people agree with this and no one objected last
time. The next appropriate step if you want the issue fixed is to file a bug
on the style guide and update it.

dave


On Thu, Dec 3, 2009 at 3:33 PM, Alexey Proskuryakov <ap at webkit.org> wrote:

>
> On 03.12.2009, at 14:22, Jens Alfke wrote:
>
>  This comes up because I have a patch out for review that includes the
>> addition of an HTTPHeaders namespace that just contains a bunch of string
>> constants:
>>
>
>
> I do not think constants for HTTP headers are part of HTTPHeaderMap - maybe
> it would be better to add them to a new file. That would resolve the issue
> with style automatically, although I agree with the rationale you provided.
>
> - WBR, Alexey Proskuryakov
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20091203/fb0d3a51/attachment.html>


More information about the webkit-dev mailing list