[webkit-dev] namespace indent
abarth at webkit.org
Tue Dec 1 13:13:56 PST 2009
The pretty diff on Bugzilla knows how to show you what's changed on a
given line (e.g., whitespace).
On Tue, Dec 1, 2009 at 1:11 PM, Rudi Sherry <rsherry at adobe.com> wrote:
> For (2), are we sure the relevant diff tools can isolate the real changes to
> those files amid mass indentation? Most if not all can, but I don't know
> about the automatic diffs that may be part of the webkit
> build/release/publish process. Not that this is a deal-breaker, but I wanted
> to bring it up.
> On Dec 1, 2009, at 12:52 PM, David Hyatt wrote:
>> On Dec 1, 2009, at 2:42 PM, Adam Barth wrote:
>>> A common "false positive" in the style-queue is as follows:
>>> Code inside a namespace should not be indented. [whitespace/indent]
>>> That's because the namespace indent rule is fairly new and its hard to
>>> fix without touching the whole file. I don't think the style-queue
>>> should be spamming bugs with non-actionable information. There seem
>>> to be a few choices:
>>> 1) Disable this warning because it's not helpful at the moment.
>>> 2) Change our code to comply with this style rule (e.g., as we touch
>>> files, fix them so that the warning doesn't occur).
>>> 3) Change our style guide to match our code.
>>> Personally, I'm in favor of (2) because it seems silly to have a rule
>>> in our style guide with which we never plan to actually comply.
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
More information about the webkit-dev