[webkit-dev] No more build breaks.
Maciej Stachowiak
mjs at apple.com
Mon Aug 17 16:49:03 PDT 2009
Hi Mark,
I think this was a needlessly rude way to address the issue. Please
try to keep things courteous on webkit-dev.
Your most important point, i.e. that 'bugzilla-tool land-diff' is
really at "early adopter" maturity and not at "everyone should use it"
maturity, was much more clear in your later, less snarky message.
That being said, now that you have stated your point, I'd like to hear
Eric's feedback on the importance of these bugs.
Regards,
Maciej
On Aug 17, 2009, at 11:41 AM, Mark Rowe wrote:
>
> On 2009-08-17, at 11:36, Eric Seidel wrote:
>
>> If you're currently using "svn commit" or "git svn dcommit" to
>> commit your patches, please consider using "bugzilla-tool land-
>> diff" instead.
>>
>> Why?
>> 1. bugzilla-tool updates (and optionally closes) the bug for you
>> when you're done.
>>
>> 2. bugzilla-tool makes a nice commit entry automatically for you
>> (not quite as cool as commit-log-editor yet, but close).
>>
>> 3. MOST IMPORTANT: bugzilla-tool land-diff will automatically
>> build and run the layout tests before landing!
>> a. Impossible break at least one platform's bots when using
>> bugzilla-tool!
>> b. Impossible to inadvertently land when the tree is red!
>
> 4. bugzilla-tool will dump lots of exciting yet irrelevant junk in
> the bug before closing it (<http://webkit.org/b/26920>). That's
> always fun!
>
> 5. In the interests of keeping life interesting, bugzilla-tool will
> sometimes commit with the wrong commit message (<http://webkit.org/b/28092
> >).
>
> - Mark
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
More information about the webkit-dev
mailing list