[webkit-dev] Some thoughts about platform flags

Amanda Walker amanda at chromium.org
Wed Sep 24 15:38:10 PDT 2008

On Wed, Sep 24, 2008 at 5:53 PM, Darin Adler <darin at apple.com> wrote:
> I think that despite its short pithy name that seems to refer to only a type
> of computer, the Mac suffix and PLATFORM(MAC) doesn't mean "code that runs
> on Mac OS X". In my opinion it doesn't mean "Apple's Mac port" either. It
> does mean, at least in part, "built on top of the Mac frameworks, Cocoa in
> particular". Just as PLATFORM(WIN) means "built on the HWND and event model
> on Windows" among other things.

Hmm.  But in both of these cases, Chromium only differs in some cases.
 For example, the Windows version is indeed based on the HWND and
event/message model on Windows, and the Mac version uses quite a lot
of Mac frameworks.  What differs is not what it uses, but rather how.
 For the parts of WebCore that draw things, we'd like to use exactly
the same code as other Mac-based versions.  But right now, rendering,
resource loading, event processing, etc. are all intermixed under the
umbrella of PLATFORM(MAC).

> So I agree that Chromium should not turn on PLATFORM(MAC) since Chromium
> does not use Mac frameworks in this way.

Hmm.  Then I think we probably need to change a number of things that
are currently keyed off of that and make them keyed off of some other
feature flag, such as CG, USE(mumble), etc.  Is making some of these
things finer-grained a reasonable approach?


More information about the webkit-dev mailing list