[webkit-dev] Fwd: Rename TypeInfo -> JSTypeInfo?

[Maciej Stachowiak]

On Sep 23, 2008, at 9:32 AM, David Kilzer wrote:

> Hi Kevin,
>
> The original message did make it to the list, but no one replied.
>
> I think the best approach is to simply create a bug on  
> bugs.webkit.org and attach a patch for review (since the wx port is  
> apparently the only one "feeling the pain" right now :).

Since this change builds ok on other Windows-based ports, in my  
opinion it would be better to fix the Wx port's build system than to  
change the header name or class name.

Regards,
Maciej

>
>
> Dave
>
>
> On Tue, 9/23/08, Kevin Ollivier <kevino at theolliviers.com> wrote:
>
>> Hi all,
>>
>> I sent this message to the mailing list yesterday, but it
>> seems it
>> never made it, so I'm resending.
>>
>> Kevin
>>
>> Begin forwarded message:
>>
>>> From: Kevin Ollivier <kevino at theolliviers.com>
>>> Date: September 22, 2008 12:13:24 PM PDT
>>> To: webkit-dev at lists.webkit.org
>>> Subject: Rename TypeInfo -> JSTypeInfo?
>>>
>>> Hi all,
>>>
>>> We're having a problem on the Windows version of
>> wxWebKit where
>>> #include <typeinfo> is actually now including
>> JavaScriptCore/kjs/
>>> TypeInfo.h, which needless to say is not a good thing.
>> ;-) I think
>>> this problem stems from the fact that we (the wx port,
>> that is)
>>> don't use the 'framework' approach for JSC
>> headers yet (and thus
>>> need JavaScriptCore/kjs on our include path), but I
>> think in general
>>> it's good practice to avoid using system header
>> names just for
>>> readability purposes. Does anyone see a problem with
>> renaming
>>> TypeInfo to JS(C)TypeInfo, both header name and class?
>>>
>>> Thanks,
>>>
>>> Kevin
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev