[webkit-dev] Geolocation questions

David Kilzer ddkilzer at webkit.org
Fri Oct 31 15:52:25 PDT 2008

On Fri, 10/31/08, Holger Freyther <zecke at selfish.org> wrote:

> Hey,
> I have started implementing  a GeoLocation service for Gtk+
> using the Gypsy 
> interface. I have some comments and questions:
> 1.) Could we remove GeolocationService::create from
> GeolocationService.cpp? 
> Any platform that intends to implement this can have this
> factory in their 
> GeolocationServiceFoo.cpp? This makes it possible to add
> and remove platforms 
> without touching this file.
> 2.) Geoposition is RefCounted but we pass Geoposition* all
> over the place? Can 
> we decide on of the two? This would also make the ownership
> more clear.
> should I send patches for the above?

Yes, please file separate bugs for each of these issues and attach the patches.  Thanks!


More information about the webkit-dev mailing list